Update ComponentDetectorCheck for ksp #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interestingly enough, the first two tests pass even before making any changes to the target class.
Note: During testing, the message returned on failure is "Source0.kt:6" for KSP whereas it is "Source0.kt:6:11" for the current implementation (and :7 instead of :7:13). Need to look into this further before calling it done.
The message returned on failure is "Source0.kt:6" for KSP whereas it is "Source0.kt:6:11" for the current implementation (and :7 instead of :7:13 for the second test) Following the same pattern as in other tests, I've removed the extra info that's not common for the two processes.
|
|
ZacSweers
approved these changes
Oct 5, 2023
15 tasks
JoelWilcox
approved these changes
Oct 19, 2023
Fixed lint formatting issues.
JoelWilcox
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds KSP support for ComponentDetectorCheck
ComponentDetectorCheckfollows the same pattern already used inAnvilAnnotationDetectorCheck. No additional logic/further changes have been introduced here.a Dagger component causes an errorincludes "Source0.kt:6" for KSP whereas it is "Source0.kt:6:11" for the current implementation. Similarly, the testa Dagger component causes an error inner classreturns ":7" instead of ":7:13".