Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ProvidesMethodFactoryCodeGen to KSP #806

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Migrate ProvidesMethodFactoryCodeGen to KSP #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eb5b9ad
Expose simpler isPublishedApi
ZacSweers Nov 25, 2023
606bfb8
Extract logic
ZacSweers Nov 25, 2023
67b984c
Fully abstract CallableReference
ZacSweers Nov 25, 2023
2b1127c
Restructure for KSP support
ZacSweers Nov 25, 2023
783a637
Extract code gen
ZacSweers Nov 25, 2023
1894be1
Support mangling and set up test
ZacSweers Nov 25, 2023
4d9b2fb
Check getter too
ZacSweers Dec 5, 2023
527bf45
KSP always resolves the return type
ZacSweers Dec 5, 2023
93966e6
More comments
ZacSweers Dec 5, 2023
1f2bb52
ktlint
ZacSweers Dec 5, 2023
b7206dc
Nix comment
ZacSweers Dec 5, 2023
303dd4f
Update test for KSP behavior
ZacSweers Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ dependencies {

compileOnly libs.auto.service.annotations
compileOnly libs.kotlin.compiler
compileOnly libs.ksp.compilerPlugin
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for internal API access, see comment below

compileOnly libs.ksp.api

kapt libs.auto.service.processor
Expand Down
19 changes: 19 additions & 0 deletions compiler/src/main/java/com/squareup/anvil/compiler/codegen/dagger/DaggerGenerationUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.google.devtools.ksp.getAnnotationsByType
import com.google.devtools.ksp.getDeclaredProperties
import com.google.devtools.ksp.getVisibility
import com.google.devtools.ksp.symbol.KSClassDeclaration
import com.google.devtools.ksp.symbol.KSFunctionDeclaration
import com.google.devtools.ksp.symbol.KSPropertyDeclaration
import com.google.devtools.ksp.symbol.KSType
import com.google.devtools.ksp.symbol.KSValueParameter
Expand Down Expand Up @@ -581,3 +582,21 @@ internal fun assertNoDuplicateFunctions(
)
}
}

internal fun assertNoDuplicateFunctions(
declaringClass: KSClassDeclaration,
functions: Sequence<KSFunctionDeclaration>,
) {
// Check for duplicate function names.
val duplicateFunctions = functions
.groupBy { it.qualifiedName!!.asString() }
.filterValues { it.size > 1 }

if (duplicateFunctions.isNotEmpty()) {
throw KspAnvilException(
node = declaringClass,
message = "Cannot have more than one binding method with the same name in " +
"a single module: ${duplicateFunctions.keys.joinToString()}",
)
}
}
Loading