fix: rename 'option' to 'control' in section controls #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laurenhu can you use |
laurenhu
changed the title
kchung
approved these changes
Mar 8, 2024
|
🎉 This PR is included in version 1.0.0-alpha.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
sohnj877
added a commit
that referenced
this pull request
Mar 28, 2024
…ore-locator * 'alpha' of https://github.com/square/brisk-theme: (52 commits) feat: use system page properties (#52) fix: rename 'option' to 'control' in section controls (#59) refactor: rename 'option' to 'control' in section controls (#57) fix: search result 500 (#54) fix: respond to breaking changes (#55) feat(async): release async template removal (#53) refactor: remove async templates (#50) ci(github-action): use latest version of checkout action (#49) ci(github-actions): fix commitlint help url config (#48) ci(github-actions): add commit linting (#47) docs: update theme version (#46) fix: banner image missing on shop all (#45) refactor(home): update home sections (#43) chore: update hooks (#42) docs: add contributing file (#41) build(github-actions): update job action versions (#40) build(github-actions): add lint action (#39) build(release): add semantic releases (#38) Fix link control Update page to use lowercase value ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors all section controls to use new
controlprop naming convection instead ofoption(optionwill remain supported for a transitional period).