Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add integrity to cdn scripts and remove unused #66

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

allensquare
Copy link
Collaborator

@allensquare allensquare requested a review from kchung June 25, 2024 23:18
@kchung
Copy link
Collaborator

kchung commented Jun 25, 2024

@allensquare i would suggest using fix over chore so that it cuts a release and generates a release notes

@allensquare allensquare changed the title chore: add integrity to cdn scripts and remove unused fix: add integrity to cdn scripts and remove unused Jun 25, 2024
Copy link
Collaborator

@kchung kchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@allensquare allensquare merged commit a68a879 into alpha Jun 25, 2024
3 checks passed
@allensquare allensquare deleted the add-js-delivr-cdn-integrity branch June 25, 2024 23:23
@kchung
Copy link
Collaborator

kchung commented Jun 25, 2024

@allensquare ah shoot, the rename should've also been done through the commit as well. I thought it would pick it up from the title but what it does is it scans all the commits and sees what version bump is needed

@allensquare
Copy link
Collaborator Author

@kchung Ahh shoot... I thought it would squash and use title as commit since the button says "Squash and merge". Any re-course or do I just manually create a new release?

@kchung
Copy link
Collaborator

kchung commented Jun 25, 2024

@allensquare yeah that's what i thought would've happened too but that's not how it works. I did this a few times: #53

@allensquare
Copy link
Collaborator Author

@kchung #67

Copy link

🎉 This PR is included in version 1.0.0-alpha.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants