Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mode to print git errors #56

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

polac24
Copy link
Collaborator

@polac24 polac24 commented Jun 27, 2023

Introducing a mode that prints git output if a command fails.

  • Pass --print_git_errors to enable that mode
  • In the verbose mode is enabled, this argument is redundant (added a warning)

image

To test, invoke git-fastclone [email protected]:githubtraining/hellogitworld.git -b 1111 --print_git_errors which will try to check out to a non-existing 111.

git-fastclone 1.4.2
Cloning hellogitworld to ..../hellogitworld
I, [2023-06-27T12:41:07.545645 #90557]  INFO -- : error: pathspec '1111' did not match any file(s) known to git

return if status.exited? && status.exitstatus == 0

logger.info(output) if print_on_failure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhh niceeeee!

@polac24 polac24 force-pushed the bartosz/20230623-fix-error-clone branch 5 times, most recently from fc550bc to 58f59b7 Compare June 27, 2023 22:26
@polac24 polac24 force-pushed the bartosz/20230623-fix-error-clone branch from 66a308e to 8ea195f Compare June 27, 2023 22:34
@polac24 polac24 merged commit aff916d into square:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants