Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for delegates to Anonymous classes #2034

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Add support for delegates to Anonymous classes #2034

merged 5 commits into from
Dec 4, 2024

Conversation

TrevorSStone
Copy link
Contributor

  • docs/changelog.md has been updated if applicable.
    • Changes not visible to library consumers, such as build script, documentation, or test code updates, don't need to
      be added to the changelog.
  • CLA signed.

Fixes #2033

Egorand
Egorand approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Egorand Egorand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix!

Left a few suggestions, would be great to incorporate them but not critical.

kotlinpoet/src/jvmTest/kotlin/com/squareup/kotlinpoet/TypeSpecTest.kt Outdated Show resolved Hide resolved
kotlinpoet/src/jvmTest/kotlin/com/squareup/kotlinpoet/TypeSpecTest.kt Outdated Show resolved Hide resolved
kotlinpoet/src/jvmMain/kotlin/com/squareup/kotlinpoet/TypeSpec.kt Outdated Show resolved Hide resolved
@Egorand
Copy link
Collaborator

Egorand commented Dec 3, 2024

@TrevorSStone can you please run ./gradlew spotlessApply and push to fix code style issues?

@Egorand Egorand merged commit bc46f4d into square:main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton left review comments

@Egorand Egorand Egorand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anonymous Class TypeSpec do not support delegates
3 participants
@TrevorSStone @Egorand @JakeWharton