Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a NodeJS canary build #1591

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Don't use a NodeJS canary build #1591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,29 +228,6 @@ subprojects {
}
}

/**
* Select a NodeJS version with WASI and WASM GC.
* https://github.com/Kotlin/kotlin-wasm-examples/blob/main/wasi-example/build.gradle.kts
*/
plugins.withType<NodeJsRootPlugin> {
extensions.getByType<NodeJsRootExtension>().apply {
if (DefaultNativePlatform.getCurrentOperatingSystem().isWindows) {
// We're waiting for a Windows build of NodeJS that can do WASM GC + WASI.
nodeVersion = "21.4.0"
} else {
nodeVersion = "21.0.0-v8-canary202309143a48826a08"
nodeDownloadBaseUrl = "https://nodejs.org/download/v8-canary"
}
}
// Suppress an error because yarn doesn't like our Node version string.
// warning You are using Node "21.0.0-v8-canary202309143a48826a08" which is not supported and
// may encounter bugs or unexpected behavior.
// error [email protected]: The engine "node" is incompatible with this module.
tasks.withType<KotlinNpmInstallTask>().all {
args += "--ignore-engines"
}
}

/**
* Set the `OKIO_ROOT` environment variable for tests to access it.
* https://publicobject.com/2023/04/16/read-a-project-file-in-a-kotlin-multiplatform-test/
Expand Down