This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test method
serialization()
tests the serialization of Json objects by comparing their string representations. Under most circumstances it won't be an issue, because it is usually expected that the fields have a fixed order.However, in terms of specification, Gson implicitly relies on calling the Java method
getDeclaredFields()
, which its documentation said:A plugin that can be useful to detect such potential problems NonDex can be used like this:
Thus, it would be safer to compare objects directly, so that this non-determinism will never generate a false alarm. By serialize and then deserialize, if the test case passes, then one can still say that the serialization is valid, because they are deserialized to the same object.
Please do reply if there are anything that can be made better for this pull request :)