Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read kotlin metadata to resolve nullability of suspending functions #3544

Open
wants to merge 17 commits into
base: trunk
Choose a base branch
from

Conversation

ferinagy
Copy link

Attempt at #3075. Any suggestions to improve are welcome.

@ZacSweers
Copy link
Contributor

Why not use kotlinx-metadata?

@cbruegg
Copy link

cbruegg commented Apr 21, 2021

@ZacSweers Due to its size: #3075 (comment)

@ZacSweers
Copy link
Contributor

That's two years old and almost certainly referring to kotlin-reflect, which is different.

@cbruegg
Copy link

cbruegg commented Apr 21, 2021

@ZacSweers
Copy link
Contributor

Sure, but that's not what the comment you linked was referring to.

@ferinagy
Copy link
Author

ferinagy commented Apr 21, 2021

Why not use kotlinx-metadata?

It's in the name of the issue #3075: "...and avoid kotlin-metadata-jvm dep". 🤷

That is actually how I started, I can fairly easily put it back. For me it shows closer to 2.7MB. It probably would be stripped by proguard/r8 a lot, since we really need just a small bit, but still.

@JakeWharton
Copy link
Collaborator

The metadata dependency is unacceptable, yes. I'll look later. Thanks for the PR.

@ferinagy
Copy link
Author

ferinagy commented May 5, 2021

Hi, no pressure here, but if I can explain or clean up the code to help with reviewing this, let me know.

@JakeWharton
Copy link
Collaborator

Earliest I'll be able to look is next week. I'm just very busy, sorry!

@Mehly
Copy link

Mehly commented Aug 10, 2021

Any update on this? :)

@ferinagy
Copy link
Author

I did another pass through this. I cleaned up some stuff, marked which parts were extracted from kotlinx-metadata-jvm and kotlinx.serialization, and added some comments to the rest. Any feedback will be appreciated.

@krokyze
Copy link

krokyze commented Dec 1, 2021

Any update on this? :)

Looks like kotlinx-metadata has a newer version which is now 1MB in size https://mvnrepository.com/artifact/org.jetbrains.kotlinx/kotlinx-metadata-jvm/0.4.0

# Conflicts:
#	retrofit/src/main/java/retrofit2/HttpServiceMethod.java
@pm-nchain
Copy link

Any updates on this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants