Updating ach example #218
Updating ach example #218
Conversation
abhipillai
force-pushed
the
updating-ach-example
branch
from
6923860
to
f8dea88
Compare
| console.error('Initializing Card failed', e); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for removing the card flow from this example. It just muddles up the example as is.
| displayPaymentResults('SUCCESS'); | ||
|
|
||
| console.debug('Payment Success', paymentResults); | ||
| tokenize(paymentMethod, options); |
There was a problem hiding this comment.
I know ACH relies mostly on the event listener, but I feel like this should still be awaited..?
There was a problem hiding this comment.
All the errors will now be captured via the listener so we don't need to await this anymore.
There was a problem hiding this comment.
In that case, the async keyword should be removed from the tokenize() method definition on line 50.
public/examples/ach.html
Outdated
| const achOptions = getACHOptions(paymentForm); | ||
| await handlePaymentMethodSubmission(event, ach, achOptions); | ||
| }); | ||
| // Checkpoint 2. |
There was a problem hiding this comment.
This checkpoint is directly at odds with the idea of this example being completely focused on ACH and ACH alone, I think checkpoint 1 was the card example. We should pick a lane here - each payment method is independent, or the examples build on each other.
Please explain the changes you made here.
Updates ACH example and removes the card element.
Does this close any currently open issues?