Exposing GrpcResponse.grpcResponseToException #2814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
force-pushed
the
bquenaudon.2024-01-31.openinggrpcResponseToException
branch
from
89f77ea
to
e8c35ab
Compare
| try { | ||
| grpcStatusDetailsBin = Base64.getDecoder().decode(it) | ||
| } catch (e: IllegalArgumentException) { | ||
| throw IOException( |
There was a problem hiding this comment.
Isn't it a bit weird that transportException is returned but this IllegarArgumentException is rethrown?
IMO it would be better to only return GrpcException from this method and throw anything else.
| var trailers = headersOf() | ||
| var transportException = suppressed | ||
| try { | ||
| trailers = trailers() |
There was a problem hiding this comment.
This method is guaranteed to throw if the response hasn't been consumed yet. It would be good to document this behavior or ensure it doesn't happen by buffering the response body here via response.peekBody()
swankjesse
reviewed
Feb 2, 2024
| var trailers = headersOf() | ||
| var transportException = suppressed | ||
| try { | ||
| trailers = trailers() |
| import okio.IOException | ||
|
|
||
| /** Returns an exception if the gRPC call didn't have a grpc-status of 0. */ | ||
| fun GrpcResponse.grpcResponseToException(suppressed: IOException? = null): IOException? { |
There was a problem hiding this comment.
I don’t think I like the signature of this function as a public API.
It’s job is to produce an exception if the response itself is malformed or bad.
Maybe this?
fun GrpcResponse.toExceptionIfFailed(suppressed: IOException? = null): IOException? {
}
|
We'll try working on interceptors instead soon. |
oldergod
deleted the
bquenaudon.2024-01-31.openinggrpcResponseToException
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with #2769. cc @sergeys-opera