Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow-ui/core module. #1185

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

MilanJovic92
Copy link
Contributor

Create workflow-ui-core KMP module.
Copied implementation from workflow-ui-core-common to the new module.

@steve-the-edwards
Copy link
Contributor

@MilanJovic92 can you give more context on why we should do this or what it accomplishes? Can you link this to an issue?

@MilanJovic92
Copy link
Contributor Author

@MilanJovic92 can you give more context on why we should do this or what it accomplishes? Can you link this to an issue?

@steve-the-edwards Of course. This PR copies everything from workflow-ui-core-common module which publishes the JVM library to the new module workflow-ui-core that will publish the KMP package.

The idea is to enable the creation of Screen and other helpful UI elements inside KMP projects that use workflow-core.

I haven't found the Issue for this, but I can create one if it's necessary.

After and if this PR gets merged, the old workflow-ui-core-common should be deleted.

@blakelee
Copy link
Collaborator

I was able to get Workflow working in my KMP project by making these changes as well as pulling in all of the classes from workflow-ui:compose and deleting ViewEnvironmentWithComposeSupport.kt along with a few other Android only functions. I'm sure there's more support needed per platform but Workflow would be great as a multiplatform option since the alternatives aren't nearly as good.

@MilanJovic92
Copy link
Contributor Author

@blakelee That's exactly what I tried to achieve with this PR. I would love to see Workflow with full-fledged support of KMP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants