Introduce ComposeWorkflow. #1357
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
1e1ef4d to
2fff3a7
Compare
This is part of go/compose-based-workflows.
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
2fff3a7 to
3f1dca8
Compare
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
8fda6f7 to
4e4029a
Compare
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
7 times, most recently
from
2b3d497 to
166d2ff
Compare
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
3 times, most recently
from
0d1f10d to
a2a6ac6
Compare
…f the underlying dispatcher.
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
78c80cb to
159aae8
Compare
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
f13e9e1 to
303a251
Compare
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
303a251 to
eeb366b
Compare
The old implementation had a bug where the dispatch loop coroutine could prevent a dispatch context from finishing. The new implementation avoids the dispatch coroutine entirely by using a special Continuation implementation.
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
7c589f0 to
72d58a8
Compare
SynchronizedMolecule fully encapsulates the Compose runtime into a clean, minimal interface with a single entry point, much like launchMolecule does. This should be much more testable, and we could potentially even pull it out into the Molecule library. It also cleans up the code inside ComposeWorkflowNodeAdapter even more.
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
2 times, most recently
from
9e79260 to
a78efa5
Compare
zach-klippenstein
force-pushed
the
zachklipp/composeworkflow2
branch
from
a78efa5 to
e565108
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of go/compose-based-workflows.