-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: external logging API #249
Open
jamieQ
wants to merge
1
commit into
main
Choose a base branch
from
jquadri/external-logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import Foundation | ||
|
||
/// Namespace for logging API used to propagate internal Workflow-related logging to external consumers | ||
public enum ExternalLogging {} | ||
|
||
extension ExternalLogging { | ||
/// Log level indicating 'severity' of the corresponding `LogEvent` | ||
public enum LogLevel { | ||
case info | ||
case error | ||
} | ||
|
||
/// A log event | ||
public struct LogEvent { | ||
public let message: String | ||
public let level: LogLevel | ||
} | ||
|
||
/// Wrapper that allows for propagating log events to outside consumers. | ||
internal struct ExternalLogger { | ||
private let implementation: (LogEvent) -> Void | ||
|
||
internal init(_ implementation: @escaping (LogEvent) -> Void) { | ||
self.implementation = implementation | ||
} | ||
|
||
internal func log(_ payload: LogEvent) { implementation(payload) } | ||
} | ||
|
||
/// Shared external logger variable | ||
internal static var logger: ExternalLogger? | ||
|
||
/// External logging bootstrapping method. | ||
/// Call once with the desired log handler. | ||
/// - Parameter logHandler: Callback to handle logging events. | ||
public static func configure( | ||
_ logHandler: @escaping (LogEvent) -> Void | ||
) { | ||
assert( | ||
logger == nil, | ||
"Workflow external logger already configured." | ||
) | ||
|
||
logger = ExternalLogger(logHandler) | ||
} | ||
} | ||
|
||
extension ExternalLogging.LogEvent { | ||
/// Convenience to create an info-level `LogEvent` | ||
static func info(_ message: String) -> Self { | ||
.init(message: message, level: .info) | ||
} | ||
|
||
/// Convenience to create an error-level `LogEvent` | ||
static func error(_ message: String) -> Self { | ||
.init(message: message, level: .error) | ||
} | ||
} | ||
|
||
extension ExternalLogging { | ||
// Logs an info message via the global logger (if set) | ||
static func logInfo(_ message: @autoclosure () -> String) { | ||
logger?.log(.info(message())) | ||
} | ||
|
||
// Logs an error message via the global logger (if set) | ||
static func logError(_ message: @autoclosure () -> String) { | ||
logger?.log(.error(message())) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the use of the name space.