Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 8/9 #58

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Laravel 8/9 #58

wants to merge 17 commits into from

Conversation

bryanrscott
Copy link
Contributor

@bryanrscott bryanrscott commented Sep 14, 2020

Suggested updates for laravel 8. I am suggesting a new branch as laravel 8 upgrades to symphony 5.
Includes edits by @npostman
Welcome any additional suggestions.

@bryanrscott
Copy link
Contributor Author

Not yet ready

@bryanrscott
Copy link
Contributor Author

Confirmed functional. Misread configuration

@bryanrscott bryanrscott reopened this Sep 14, 2020
@npostman
Copy link

Implemented and confirmed to work with L8.6.0. Thanks @bryanrscott

@vinayak25 vinayak25 self-requested a review September 30, 2020 18:36
@bryanrscott
Copy link
Contributor Author

bryanrscott commented Oct 8, 2020

Acknowledgement link for @npostman
#57

@ahosker
Copy link

ahosker commented Oct 9, 2020

Up and running in Laravel 8. Thanks @bryanrscott

README.md Outdated
@@ -10,6 +10,7 @@ An easy way to send emails with stack trace whenever an exception occurs on the

#### For Laravel <= 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)!
#### For Laravel 5.2 < version <= 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)!
#### For Laravel 6.x < version <= 8.x, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a bit confusing because of the .x at the start.
I recommend changing it into "For Laravel 7.0 <= version <= 8.x" 😊
And while you're at it, I recommend also changing that second line into "For Laravel 5.3 <= version ..." then...

Less brain cells wasted for developers trying to figure out which branch they need 😊

Clarity recommendations from @JorisDebonnet
@bryanrscott
Copy link
Contributor Author

@JorisDebonnet Agree and have updated README as suggested

Add user details to email message
@JorisDebonnet
Copy link

JorisDebonnet commented Nov 16, 2020

@JorisDebonnet Agree and have updated README as suggested

Okay, uh, but it's not 100% as I meant now 😄
My suggestion for the 'mathematically most correct' version was this:

#### For Laravel <= 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)!
#### For Laravel 5.3 <= version <= 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)!
#### For Laravel 7.0 <= version <= 8.x, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)!

Alternatively, 'plain English' could be even easier to read:

#### For Laravel up to 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)!
#### For Laravel 5.3 to 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)!
#### For Laravel 7 and up, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)!

Or did I misunderstand, and does Laravel 7 require a separate branch from Laravel 8+? Then I guess the last line would need to say "for Laravel 7.x, please use ..."

version texts
@bryanrscott
Copy link
Contributor Author

Yes Laravel 8 would need a seperate branch.

@squareboat squareboat locked and limited conversation to collaborators Dec 10, 2020
@squareboat squareboat unlocked this conversation Dec 10, 2020
@jvandervalk
Copy link

Hopefully Laravel support for version 8 can be added soon.

@JorisDebonnet
Copy link

Hopefully Laravel support for version 8 can be added soon.

For what it's worth, here's how to use bryanrscott's fork in your own project (that's what I'm doing at the moment) in order to use Sneaker with Laravel 8:

composer.json

{
    "require": {
        "squareboat/sneaker": "dev-master"
    },
    "repositories": [ { "type": "vcs", "url": "https://github.com/bryanrscott/sneaker" } ],
}

This was referenced Apr 7, 2021
@michaelheumann
Copy link

Hi, I just ported my application to Laravel 8 and Sneaker does not seem to work. I have run into this same issue when porting to Laravel 6 and 7, and it was due to the composer version (I had to downgrade composer to 1.10). But now this happens both with composer 1 and 2.

This is the message at the end of composer install:

Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover

In Container.php line 835:
                                          
  Target class [sneaker] does not exist.  
                                          

In Container.php line 833:
                                
  Class sneaker does not exist  

Do ypu have a workaround for this?

@bryanrscott
Copy link
Contributor Author

@michaelheumann I would recommend
a) use composer 2
b) uninstall sneaker, including commenting out the lines in app/Exceptions/Handler.php
c) composer update
d) install sneaker via composer
e) complete install by uncommenting lines in app/Exceptions/Handler.php

@npostman
Copy link

npostman commented Mar 2, 2022

@bryanrscott Thanks for keeping this nice package up to date!

@eugenefvdm
Copy link

Curious if this project has stalled or if it's possible to install in Laravel 8, or even better, Laravel 9?

@bryanrscott bryanrscott changed the title Laravel 8 Laravel 8/9 Nov 3, 2022
@bryanrscott
Copy link
Contributor Author

@ eugenevdm the forked version supports Laravel 9

1 similar comment
@bryanrscott
Copy link
Contributor Author

@ eugenevdm the forked version supports Laravel 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants