-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Module. #24
Open
rachit89
wants to merge
39
commits into
squareops:main
Choose a base branch
from
rachit89:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updated Module. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made to the files for main.tf , output.tf . variables.tf in calling module & examples.
Made changes to main.tf & variable.tf for variables.
Changed the hashicorp version for aws from 4.23 to 5.0.0
Changed aws hashicorp version from 4.23 to 5.0.0
1. Added a logic so that the user can provide number of desired subnets want to create.
Feature/release01
Feature/release01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Updated ecr api endpoint policy.
2.Made the module for key par vpn conditional . Should be created only when vpn_server_enabled is set to true.
3.Updated VPC module for the vpn server key pair name . It should take the key from key pair module if vpn server enabled is set to true or else it should take empty.
4.Updated README.md for example.