-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed and redefined total peering time (%<tt) #1828
Fixed and redefined total peering time (%<tt) #1828
Commits on Mar 24, 2024
-
Fix proxy processing time for pinned connections
[http]::<tt was empty for bumped at 2/3 step configurations (both fwd and tunnel) because HierarchyLogEntry::startPeerClock() was not called for pinned connections. Also adjusted [http]::<tt definition to account for the peer lookup stage (which runs in parallel with connect attempts). Also fixed [http]::<tt for peek-and-splice step 2/3 configurations when a TLS error initiates switchToTunnel(). In this case, the logged time covered only the interval up to the failed TLS attempt and did not include the rest of the tunnel communication.
Configuration menu - View commit details
-
Copy full SHA for b2193b4 - Browse repository at this point
Copy the full SHA b2193b4View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2313710 - Browse repository at this point
Copy the full SHA 2313710View commit details -
Removed an excessive stopPeerClock() from FwdState::retryOrBail()
and a couple of polishing changes.
Configuration menu - View commit details
-
Copy full SHA for 8688bb5 - Browse repository at this point
Copy the full SHA 8688bb5View commit details
Commits on Mar 28, 2024
-
Drop nil checks for always-present TunnelStateData::request
and a couple of polishing changes.
Configuration menu - View commit details
-
Copy full SHA for 9ee4c5a - Browse repository at this point
Copy the full SHA 9ee4c5aView commit details -
Documented the effects of secondary activities and re-forwarding
Also documented what should happen when the %code is used before the timer stops. XXX: That is not what happens right now.
Configuration menu - View commit details
-
Copy full SHA for c834331 - Browse repository at this point
Copy the full SHA c834331View commit details
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a71a763 - Browse repository at this point
Copy the full SHA a71a763View commit details
Commits on Apr 8, 2024
-
Removed an excessive stopPeerClock()
The only stopPeerClock() left is in FwdState::stopAndDestroy(), which covers all cases (sucess, error) when communication with the last peer terminates.
Configuration menu - View commit details
-
Copy full SHA for 182b682 - Browse repository at this point
Copy the full SHA 182b682View commit details
Commits on Apr 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2c176f - Browse repository at this point
Copy the full SHA a2c176fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2637ca - Browse repository at this point
Copy the full SHA c2637caView commit details
Commits on Apr 11, 2024
-
Overcome the unassigned ALE totalResponseTime()
In this temporary approach the time is taken from HttpRequest::hier. Also polished and simplified.
Configuration menu - View commit details
-
Copy full SHA for 94bb99b - Browse repository at this point
Copy the full SHA 94bb99bView commit details
Commits on Apr 14, 2024
-
* do not dereference a possibly nil al->request * optimized %<tt formatting code
Configuration menu - View commit details
-
Copy full SHA for 0a2b9b4 - Browse repository at this point
Copy the full SHA 0a2b9b4View commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e192dc - Browse repository at this point
Copy the full SHA 9e192dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8ac2b7 - Browse repository at this point
Copy the full SHA c8ac2b7View commit details -
Removed the branch-added tunneled flag
We do not need this flag anymore since Stopwatch can track multiple resumes and pauses.
Configuration menu - View commit details
-
Copy full SHA for 5fb6a31 - Browse repository at this point
Copy the full SHA 5fb6a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86033b5 - Browse repository at this point
Copy the full SHA 86033b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9340dac - Browse repository at this point
Copy the full SHA 9340dacView commit details
Commits on Apr 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8092565 - Browse repository at this point
Copy the full SHA 8092565View commit details -
Removed the peeringTime_.running() assurance from TunnelStateData
It turned out that we cannot guarantee that condition when switchToTunnel() was initiated by noteTakeServerConnectionControl(). In this case, FwdState is destroyed after TunnelStateData, and therefore the timer is still 'running' in TunnelStateData destructor.
Configuration menu - View commit details
-
Copy full SHA for a693219 - Browse repository at this point
Copy the full SHA a693219View commit details
Commits on Apr 18, 2024
-
Added an ActivityTimer wrapper for Stopwatch
thus addressing problems outlined in a693219.
Configuration menu - View commit details
-
Copy full SHA for b9347ee - Browse repository at this point
Copy the full SHA b9347eeView commit details -
Polished and removed a stale TODO
The TODO looks irrelevant, since we do not (re)start peer clock in TunnelStateData::startConnecting(), but still need to reset hier.peer_reply_status there.
Configuration menu - View commit details
-
Copy full SHA for 8c86590 - Browse repository at this point
Copy the full SHA 8c86590View commit details
Commits on Apr 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 80eed21 - Browse repository at this point
Copy the full SHA 80eed21View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9c2c01 - Browse repository at this point
Copy the full SHA a9c2c01View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d4b420d - Browse repository at this point
Copy the full SHA d4b420dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe72ba9 - Browse repository at this point
Copy the full SHA fe72ba9View commit details -
Addressed HierarchyLogEntry::totalPeeringTime lifetime concerns
... documented in the previous branch commit XXX. I am not sure this complexity is warranted, but storing a raw pointer to a disappearing object (for some definition of "disappearing") did not feel right either. This is the best solution I could find.
Configuration menu - View commit details
-
Copy full SHA for fa32752 - Browse repository at this point
Copy the full SHA fa32752View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95c3e8a - Browse repository at this point
Copy the full SHA 95c3e8aView commit details -
fixup: Simplified ActivityTimer code by making the class less general
It is difficult to justify paying significant price for supporting future hypothetical use cases, especially when we can add support for other use cases (and make the class more complex) as needed instead.
Configuration menu - View commit details
-
Copy full SHA for 48b31b2 - Browse repository at this point
Copy the full SHA 48b31b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3ee47b - Browse repository at this point
Copy the full SHA f3ee47bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f59c5 - Browse repository at this point
Copy the full SHA 95f59c5View commit details -
fixup: Restored branch-removed assertions
They are no longer needed, but it is probably best to remove them when refactoring this code to replace member assignments with member initialization code. While at it, we should consider either adding RefCount and CbcPointer methods to guarantee object existence (similar to std::optional::value() and std::vector::at()) OR a global function providing that same guarantees for any pointer-like object.
Configuration menu - View commit details
-
Copy full SHA for 8755344 - Browse repository at this point
Copy the full SHA 8755344View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ccfd0a - Browse repository at this point
Copy the full SHA 2ccfd0aView commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 02cf233 - Browse repository at this point
Copy the full SHA 02cf233View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7236dc - Browse repository at this point
Copy the full SHA c7236dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4443bdf - Browse repository at this point
Copy the full SHA 4443bdfView commit details