Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and redefined total peering time (%<tt) #1828

Commits on Mar 24, 2024

  1. Fix proxy processing time for pinned connections

    [http]::<tt was empty for bumped at 2/3 step configurations
    (both fwd and tunnel) because HierarchyLogEntry::startPeerClock()
    was not called for pinned connections.
    
    Also adjusted [http]::<tt definition to account for the peer lookup
    stage (which runs in parallel with connect attempts).
    
    Also fixed [http]::<tt for peek-and-splice step 2/3 configurations when
    a TLS error initiates switchToTunnel(). In this case, the logged
    time covered only the interval up to the failed TLS attempt and
    did not include the rest of the tunnel communication.
    eduard-bagdasaryan committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    b2193b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    2313710 View commit details
    Browse the repository at this point in the history
  2. Removed an excessive stopPeerClock() from FwdState::retryOrBail()

    and a couple of polishing changes.
    eduard-bagdasaryan committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8688bb5 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Drop nil checks for always-present TunnelStateData::request

    and a couple of polishing changes.
    eduard-bagdasaryan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9ee4c5a View commit details
    Browse the repository at this point in the history
  2. Documented the effects of secondary activities and re-forwarding

    Also documented what should happen when the %code is used before
    the timer stops. XXX: That is not what happens right now.
    rousskov committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c834331 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    a71a763 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Removed an excessive stopPeerClock()

    The only stopPeerClock() left is in FwdState::stopAndDestroy(),
    which covers all cases (sucess, error) when communication
    with the last peer terminates.
    eduard-bagdasaryan committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    182b682 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    a2c176f View commit details
    Browse the repository at this point in the history
  2. Fixed unit tests

    eduard-bagdasaryan committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c2637ca View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Overcome the unassigned ALE totalResponseTime()

    In this temporary approach the time is taken from HttpRequest::hier.
    Also polished and simplified.
    eduard-bagdasaryan committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    94bb99b View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. A couple of fixes

    * do not dereference a possibly nil al->request
    * optimized %<tt formatting code
    eduard-bagdasaryan committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    0a2b9b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    9e192dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8ac2b7 View commit details
    Browse the repository at this point in the history
  3. Removed the branch-added tunneled flag

    We do not need this flag anymore since Stopwatch can track
    multiple resumes and pauses.
    eduard-bagdasaryan committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5fb6a31 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    86033b5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9340dac View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    8092565 View commit details
    Browse the repository at this point in the history
  2. Removed the peeringTime_.running() assurance from TunnelStateData

    It turned out that we cannot guarantee that condition when
    switchToTunnel() was initiated by noteTakeServerConnectionControl(). In
    this case, FwdState is destroyed after TunnelStateData, and therefore
    the timer is still 'running' in TunnelStateData destructor.
    eduard-bagdasaryan committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a693219 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Added an ActivityTimer wrapper for Stopwatch

    thus addressing problems outlined in a693219.
    eduard-bagdasaryan committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b9347ee View commit details
    Browse the repository at this point in the history
  2. Polished and removed a stale TODO

    The TODO looks irrelevant, since we do not (re)start peer clock
    in TunnelStateData::startConnecting(), but still need to
    reset hier.peer_reply_status there.
    eduard-bagdasaryan committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8c86590 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    80eed21 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a9c2c01 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    d4b420d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe72ba9 View commit details
    Browse the repository at this point in the history
  3. Addressed HierarchyLogEntry::totalPeeringTime lifetime concerns

    ... documented in the previous branch commit XXX.
    
    I am not sure this complexity is warranted, but storing a raw pointer to
    a disappearing object (for some definition of "disappearing") did not
    feel right either. This is the best solution I could find.
    rousskov committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fa32752 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95c3e8a View commit details
    Browse the repository at this point in the history
  5. fixup: Simplified ActivityTimer code by making the class less general

    It is difficult to justify paying significant price for supporting
    future hypothetical use cases, especially when we can add support for
    other use cases (and make the class more complex) as needed instead.
    rousskov committed May 31, 2024
    Configuration menu
    Copy the full SHA
    48b31b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f3ee47b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    95f59c5 View commit details
    Browse the repository at this point in the history
  8. fixup: Restored branch-removed assertions

    They are no longer needed, but it is probably best to remove them when
    refactoring this code to replace member assignments with member
    initialization code. While at it, we should consider either adding
    RefCount and CbcPointer methods to guarantee object existence (similar
    to std::optional::value() and std::vector::at()) OR a global function
    providing that same guarantees for any pointer-like object.
    rousskov committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8755344 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2ccfd0a View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    02cf233 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7236dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4443bdf View commit details
    Browse the repository at this point in the history