Remove peerDigestFetchStop() and peerDigestFetchAbort() wrappers #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These wrappers were left behind in f036532 as diff reducers. Now we clean this up and just call peerDigestReqFinish() instead.
to minimize PR changes.
squid-anubis
added
the
M-failed-description
rousskov
changed the title
squid-anubis
removed
the
M-failed-description
rousskov
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Jul 19, 2024
These wrappers were left in recent commit f036532 to reduce noise. Now we always call finishAndDeleteFetch() directly (instead of sometimes going through those wrappers). The new function name helps reduce the number of use-after-free bugs in this code.
squid-anubis
added
the
M-waiting-staging-checks
rousskov
removed
the
S-could-use-an-approval
squid-anubis
added
M-failed-staging-checks
rousskov
removed
the
M-failed-staging-checks
squid-anubis
added
M-waiting-staging-checks
kinkie
removed
the
M-failed-staging-checks
squid-anubis
added
the
M-failed-staging-checks
kinkie
removed
the
M-failed-staging-checks
|
@eduard-bagdasaryan please merge the latest changes from master branch into this one to fix the build CI issues. |
squid-anubis
pushed a commit
that referenced
this pull request
Aug 8, 2024
These wrappers were left in recent commit f036532 to reduce noise. Now we always call finishAndDeleteFetch() directly (instead of sometimes going through those wrappers). The new function name helps reduce the number of use-after-free bugs in this code.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Oct 12, 2024
…id-cache#1869) These wrappers were left in recent commit f036532 to reduce noise. Now we always call finishAndDeleteFetch() directly (instead of sometimes going through those wrappers). The new function name helps reduce the number of use-after-free bugs in this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These wrappers were left in recent commit f036532 to reduce noise. Now
we always call finishAndDeleteFetch() directly (instead of sometimes
going through those wrappers). The new function name helps reduce the
number of use-after-free bugs in this code.