Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: split SUBDIRS in Makefile.am #1888

Closed
wants to merge 2 commits into from
Closed

Maintenance: split SUBDIRS in Makefile.am #1888

wants to merge 2 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Aug 18, 2024 •
edited by rousskov
Loading

Single-line multi-entry SUBDIRS often increase management noise.

kinkie and others added 2 commits August 18, 2024 22:48
@kinkie
Maintenance: split SUBDIRS in Makefile.am
d29c5b3 
Single-line SUBDIR clauses can be hard to
manage. Split them into multiple lines
with continuations.
@rousskov
fixup: Improve first line formatting consistency
e47a97b
rousskov
rousskov approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving SUBDIRS and related lines.

I adjusted one of the SUBDIRS lines further to remove an unusual tab and polished PR description (primarily to fix SUBDIRS spelling). Please undo or adjust further as needed.

@rousskov rousskov added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Aug 19, 2024
squid-anubis pushed a commit that referenced this pull request Aug 21, 2024
@kinkie @squid-anubis
Maintenance: split SUBDIRS in Makefile.am (#1888)
ebbcff2 
Single-line multi-entry SUBDIRS often increase management noise.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Aug 21, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Aug 21, 2024
kinkie added a commit to kinkie/squid that referenced this pull request Oct 12, 2024
@kinkie
Maintenance: split SUBDIRS in Makefile.am (squid-cache#1888)
9f8161b 
Single-line multi-entry SUBDIRS often increase management noise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinkie @rousskov @squid-anubis