Fix Comm::TcpAcceptor::status() reporting of listening address #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buggy "static" caching optimization led to TcpAcceptor X reporting listening address of TcpAcceptor Y or an incorrect 0.0.0.0 address. TcpAcceptor status is visible in mgr:jobs and level-5+ debugs() output. Side effect: For a listening port configured without an explicit IP address, the listening address part of status() is now reported using "[::]" rather than "0.0.0.0" string. Broken since 2011 commit cbff89b.
rousskov
added
M-cleared-for-merge
kinkie
approved these changes
Aug 21, 2024
squid-anubis
pushed a commit
that referenced
this pull request
Aug 22, 2024
Buggy "static" caching optimization led to TcpAcceptor X reporting listening address of TcpAcceptor Y or an incorrect 0.0.0.0 address. TcpAcceptor status is visible in mgr:jobs and level-5+ debugs() output. Side effect: For a listening port configured without an explicit IP address, the listening address part of status() is now reported using "[::]" rather than "0.0.0.0" string. Broken since 2011 commit cbff89b.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Oct 12, 2024
…-cache#1891) Buggy "static" caching optimization led to TcpAcceptor X reporting listening address of TcpAcceptor Y or an incorrect 0.0.0.0 address. TcpAcceptor status is visible in mgr:jobs and level-5+ debugs() output. Side effect: For a listening port configured without an explicit IP address, the listening address part of status() is now reported using "[::]" rather than "0.0.0.0" string. Broken since 2011 commit cbff89b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buggy "static" caching optimization led to TcpAcceptor X reporting
listening address of TcpAcceptor Y or an incorrect 0.0.0.0 address.
TcpAcceptor status is visible in mgr:jobs and level-5+ debugs() output.
Side effect: For a listening port configured without an explicit IP
address, the listening address part of status() is now reported using
"[::]" rather than "0.0.0.0" string.
Broken since 2011 commit cbff89b.