Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTTP status codes #1942

Closed
wants to merge 3 commits into from
Closed

Update HTTP status codes #1942

wants to merge 3 commits into from

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Nov 10, 2024 •
edited by rousskov
Loading

Also remove comments that replicate what the registry documents.

kinkie
kinkie previously approved these changes Nov 10, 2024
View reviewed changes
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Nov 10, 2024
@rousskov rousskov self-requested a review November 11, 2024 01:16
rousskov
rousskov reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added second commit (i.e. C++ comments removal) reasoning to PR description.

src/http/StatusCode.h Outdated Show resolved Hide resolved
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Nov 11, 2024
@yadij @rousskov
Update src/http/StatusCode.h
7164754 
Co-authored-by: Alex Rousskov <[email protected]>
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) and removed S-waiting-for-author author action is expected (and usually required) labels Nov 11, 2024
squid-anubis pushed a commit that referenced this pull request Nov 12, 2024
@yadij @squid-anubis
Update HTTP status codes (#1942)
187bb5d 
Also remove comments that replicate what the registry documents.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 12, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinkie kinkie kinkie approved these changes

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yadij @rousskov @kinkie @squid-anubis