v6 Next Backports #1947
Open
v6 Next Backports #1947
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MemPoolMalloc code (i.e. memory_pools code used by default) was missing VALGRIND_MAKE_MEM_*() calls. Similar calls do exist in MemPoolChunked code (i.e. code enabled by setting MEMPOOLS environment variable to 1). Even with these markings, "memory_pools on" configuration is still not quite compatible with Valgrind leak reporting suppressions: In some cases, Valgrind may still incorrectly suppress leak reporting (or report leaks that should have been suppressed) because Valgrind associates leak suppressions with memory _allocators_ while buggy code may leak memory allocated by others. The long-term solution (if it exists) requires upgrading these markings to VALGRIND_MEMPOOL_*() API targeting memory pools, but that requires a serious effort, especially when dealing with MemPoolChunked complexities. The added markings help detect non-leak violations and improve PoolMalloc/MemPoolChunked code symmetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.