Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add FreeBSD build tests for staged commits #1948

Closed
wants to merge 28 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Nov 18, 2024

Use a GitHub-hosted VM to create FreeBSD test environment.

We have not enabled ccache optimization for FreeBSD tests because we
do not know how to copy updated ccache files from VM back into runner.

@kinkie
Copy link
Contributor Author

kinkie commented Nov 18, 2024

test run: https://github.com/kinkie/squid/actions/runs/11882745983
It is to be verified if "vmactions" actions are authorized to run in Squid,
I can't test it on my own repository

@rousskov rousskov self-requested a review November 18, 2024 18:04
.github/workflows/openbsd.yaml Outdated Show resolved Hide resolved
.github/workflows/openbsd.yaml Outdated Show resolved Hide resolved
.github/workflows/openbsd.yaml Outdated Show resolved Hide resolved
.github/workflows/openbsd.yaml Outdated Show resolved Hide resolved
.github/workflows/slow.yaml Outdated Show resolved Hide resolved
.github/workflows/openbsd.yaml Outdated Show resolved Hide resolved
@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label Nov 18, 2024
@kinkie kinkie requested a review from rousskov November 18, 2024 19:21
@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Nov 18, 2024
.github/workflows/slow.yaml Outdated Show resolved Hide resolved
.github/workflows/slow.yaml Outdated Show resolved Hide resolved
.github/workflows/slow.yaml Outdated Show resolved Hide resolved
.github/workflows/slow.yaml Outdated Show resolved Hide resolved
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Nov 18, 2024
@rousskov rousskov changed the title Add FreeBSD staging checks CI: Add FreeBSD to GitHub Actions build tests Nov 18, 2024
@rousskov rousskov changed the title CI: Add FreeBSD to GitHub Actions build tests CI: Add FreeBSD build tests for staged commits Nov 18, 2024
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Nov 20, 2024
Co-authored-by: Alex Rousskov <[email protected]>
@kinkie kinkie requested a review from rousskov November 20, 2024 14:06
@kinkie
Copy link
Contributor Author

kinkie commented Nov 20, 2024

ccache doesn't work, ccache-action is not compatible with vmaction

I saw ccache being used to build Squid, and some ccache-related files being copied to and from VM, but I am guessing that is not enough. Just for my own edification (this is not a change request), do you know what makes the two actions incompatible?

In https://github.com/kinkie/squid/actions/runs/11917155891/job/33211530535 , ccache stats show 0 across the board.
This is because in the 'Test builds' stage, the cache directory is not copied back from the VM to the worker environment, therefore it is not saved across builds; in other words, at this time it's a waste of resources

@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Nov 20, 2024
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccache doesn't work, ccache-action is not compatible with vmaction

In https://github.com/kinkie/squid/actions/runs/11917155891/job/33211530535 , ccache stats show 0 across the board. This is because in the 'Test builds' stage, the cache directory is not copied back from the VM to the worker environment

#[group]Initialize files in VM
sending incremental file list
squid/squid/.ccache/0/0/stats
... more ccache files follow ...

##[group]Copy files back from the VM
receiving incremental file list
... no ccache files at all on this list ...

Thank you for this research. I added the corresponding text to PR description.

.github/workflows/slow.yaml Outdated Show resolved Hide resolved
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Nov 20, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Nov 20, 2024

@kinkie
Copy link
Contributor Author

kinkie commented Nov 20, 2024

Thanks for approving!

@kinkie
Copy link
Contributor Author

kinkie commented Nov 20, 2024

Trying to land this; if the actions need to be approved, I'll authorize them as needed.

@kinkie kinkie added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-author author action is expected (and usually required) labels Nov 20, 2024
squid-anubis pushed a commit that referenced this pull request Nov 20, 2024
Use a GitHub-hosted VM to create FreeBSD test environment.

We have not enabled ccache optimization for FreeBSD tests because we
do not know how to copy updated ccache files from VM back into runner.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 20, 2024
@kinkie kinkie removed the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 21, 2024
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 21, 2024
kinkie added a commit that referenced this pull request Nov 21, 2024
Use a GitHub-hosted VM to create FreeBSD test environment.

We have not enabled ccache optimization for FreeBSD tests because we
do not know how to copy updated ccache files from VM back into runner.
@kinkie kinkie removed the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 21, 2024
@squid-anubis squid-anubis added the M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 21, 2024
@kinkie kinkie removed the M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 21, 2024
squid-anubis pushed a commit that referenced this pull request Nov 21, 2024
Use a GitHub-hosted VM to create FreeBSD test environment.

We have not enabled ccache optimization for FreeBSD tests because we
do not know how to copy updated ccache files from VM back into runner.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 21, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants