Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: use void return for commSetTimeout functions #1956

Closed
wants to merge 4 commits into from
Closed

Maintenance: use void return for commSetTimeout functions #1956

wants to merge 4 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Dec 1, 2024 •
edited by rousskov
Loading

On some systems (e.g. Linux), time_t is a signed 64-bit integer. int may
be a signed 32-bit integer, resulting in possible truncation errors.

Detected by Coverity. CID 1547031: Use of 32-bit time_t (Y2K38_SAFETY).

@kinkie kinkie changed the title use time_t for comm{Set,Unset}ConnTimeout Maintenance: use time_t for commSetTimeout functions Dec 1, 2024
@squid-anubis squid-anubis added the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Dec 1, 2024
@yadij
Copy link
Contributor

yadij commented Dec 1, 2024

Looking at all the callers for these functions I think it would be better to remove the return type entirely.

  • commUnsetConnTimeout() return is never used.
  • commSetConnTimeout() return is only used as the return for commUnsetConnTimeout()

@yadij yadij changed the title Maintenance: use time_t for commSetTimeout functions Maintenance: use void return for commSetTimeout functions Dec 2, 2024
@squid-anubis squid-anubis removed the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Dec 2, 2024
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Dec 2, 2024
rousskov
rousskov approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted PR description to reduce duplication, to format it, and to specify Coverity defect type ID.

@rousskov rousskov removed the S-could-use-an-approval An approval may speed this PR merger (but is not required) label Dec 2, 2024
squid-anubis pushed a commit that referenced this pull request Dec 2, 2024
@kinkie @squid-anubis
Maintenance: use void return for commSetTimeout functions (#1956)
9685cb7 
On some systems (e.g. Linux), time_t is a signed 64-bit integer. int may
be a signed 32-bit integer, resulting in possible truncation errors.

Detected by Coverity. CID 1547031: Use of 32-bit time_t (Y2K38_SAFETY).
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Dec 2, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

@yadij yadij yadij approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinkie @yadij @rousskov @squid-anubis