Portability: remove explicit check for libdl #1963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squid-anubis
added
M-failed-description
rousskov
reviewed
Dec 16, 2024
rousskov
added
the
S-waiting-for-author
done |
kinkie
added
S-waiting-for-more-reviewers
rousskov
approved these changes
Dec 16, 2024
What happened? If that removed code happens to be needed, please consider updating the existing comment to document that newly discovered or confirmed need. |
doh. Pushed the wrong button, sorry |
|
OpenBSD test build in github actions workflow |
|
I confirm that the OpenBSD build works with this change, and there is no regression on Linux. |
yadij
added
M-cleared-for-merge
yadij
approved these changes
Dec 16, 2024
squid-anubis
pushed a commit
that referenced
this pull request
Dec 16, 2024
OpenBSD does not have libdl, as it has dlopen() in libc.
It is not really needed, and force-requiring the presence of libdl
causes ./configure to fail on openbsd:
checking for dlopen in -ldl... no
configure: error: Required library 'dl' not found
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD does not have libdl, as it has dlopen() in libc.
It is not really needed, and force-requiring the presence of libdl
causes ./configure to fail on openbsd: