Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ntlm_smb_lm_auth helper #2012

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Mar 5, 2025

This helper implementation is based on an old snapshot and adaptation of
Samba code. Samba project offers a more secure and better maintained
tool.

@squid-anubis squid-anubis added M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels labels Mar 5, 2025
@yadij

This comment was marked as resolved.

@kinkie kinkie force-pushed the remove-lanman-02 branch from 91e7a09 to fb12872 Compare March 5, 2025 08:31
@kinkie

This comment was marked as resolved.

@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label Mar 5, 2025
Damn you muscle memory

Co-authored-by: Amos Jeffries <[email protected]>
@kinkie kinkie requested a review from yadij March 5, 2025 16:13
@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box S-waiting-for-more-reviewers needs a reviewer and/or a second opinion and removed S-waiting-for-author author action is expected (and usually required) labels Mar 5, 2025
yadij
yadij previously approved these changes Mar 5, 2025
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels feature maintainer needs documentation updates for merge S-could-use-an-approval An approval may speed this PR merger (but is not required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box S-waiting-for-more-reviewers needs a reviewer and/or a second opinion labels Mar 5, 2025
missed that these should be alphabetical order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature maintainer needs documentation updates for merge M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants