CI: fix cgo profiles #227
Merged
CI: fix cgo profiles #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
|
Waiting for src-d/go-oniguruma#1 to be merged to migrate |
|
src-d/go-oniguruma#1 is merged now, waiting for a release, then updating enry to use it here, and 🔪 a new release as soon as this is merged! |
Signed-off-by: Alexander Bezzubov <[email protected]>
A result of: ``` go get github.com/src-d/go-onigoruma go mod tidy ``` Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
|
CI is green and it's ready for review. |
dennwc
approved these changes
May 8, 2019
creachadair
approved these changes
May 8, 2019
internal/tokenizer/tokenize_test.go
Outdated
| }{ | ||
| {[]byte("th\xe0 filling"), []string{"th", "filling"}}, // `th� filling` | ||
| {[]byte("th\u0100 filling"), []string{"th", "filling"}}, // `thĀ filling` | ||
| {[]byte("привет, как дела?"), []string{}}, // empty, no ASCII tokens |
Signed-off-by: Alexander Bezzubov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MustCompileASCII()from Add ASCII-only option, to mimic default RE2 behavior go-oniguruma#1