Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/after - revert after loading of syntax themes #123

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix/after - revert after loading of syntax themes #123

merged 2 commits into from
Sep 17, 2024

Conversation

roosta
Copy link
Member

@roosta roosta commented Sep 16, 2024

Fix/after - revert after loading of syntax themes

Move everything back into the original colors file, loading syntax from after can cause issues.
For example, some file colors would change when sourcing vimrc, while others was colored inconsistently, I noticed this in clojure, where the correct colors wasn't applied. I've been running this branch for a bit, and everything seems in order.

Ref

Basically reverting PR #84. The after solution for syntax highlighting
is inconsistent, and certain filetype will show different colors
depending on when you source your config

ref: dracula/vim#321
Move autoloaded palette, highlight to color/srcery.vim.

We don't have to reference this in multiple script files, so I've moved
it back into the main colors file
@roosta roosta requested a review from MindTooth September 16, 2024 13:35
Copy link
Member

@MindTooth MindTooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

I always want to grok the dynamic loading of Vim code, but feel that I never get it right. Obviously, it can be difficult as we see with this.

@roosta roosta merged commit 8fc46b6 into master Sep 17, 2024
1 check passed
@roosta roosta deleted the fix/after branch September 17, 2024 15:29
@roosta
Copy link
Member Author

roosta commented Sep 17, 2024

yeah, seems loading this way is unsuited for colorschemes. an added benefit is that now I think you could get by with just colors/srcery.vim again, not necessarily relying on a package manager to get it installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorscheme applied inconsistently
2 participants