Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use --directory-prefix= #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Goddard
Copy link

@Goddard Goddard commented Jul 18, 2021

use --directory-prefix= in case the directory path doesn't exist

use --directory-prefix= in case the directory path doesn't exist
@vercel
Copy link

vercel bot commented Jul 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/srevinsaju/zap/HReZgiUejJTp2FEmcNBj5EZLyENR
✅ Preview: https://zap-git-fork-goddard-patch-1-srevinsaju.vercel.app

@srevinsaju
Copy link
Owner

But... --directory-prefix just creates the directory, right? Here, we are also overriding the file name.

Right now.. if this command is executed by a user:

  1. ~/.local/bin/zap directory will be created
  2. The zap-amd64 file will be placed in ~/.local/bin/zap/., so the net resulting path of the binary would be ~/.local/bin/zap/zap-amd64. However, most $PATH definitions on linux only adds ~/.local/bin to $PATH, and that means, the user won't be able to invoke zap using its endpoint, zap right? and even if ~/.local/bin/zap/. was added to $PATH, user would have to use zap-amd64 to invoke zap instead of just zap.

srevinsaju added a commit that referenced this pull request Jul 18, 2021
Helps to get rid of some confusion in new users. 

Inspired by #25
@srevinsaju
Copy link
Owner

I added a commit 279370c to make it more intuitive. Now it additionally, creates the directories. Let me know if you have a better solution 😄

@Goddard
Copy link
Author

Goddard commented Jul 18, 2021

yeah that definitely works. I just didn't want to make it multiple commands.

Also I think the instructions tell people to run command zap, but the binary downloaded is zap-amd64. So it either needs to add some kind of alias, or something.

Another problem is that the binary folder isn't actually in the $PATH on my machine.

@srevinsaju srevinsaju force-pushed the main branch 2 times, most recently from 060ddaa to f54936f Compare September 19, 2021 12:47
@srevinsaju srevinsaju force-pushed the main branch 2 times, most recently from 38c27b8 to d13a35f Compare November 22, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants