Fail correctly if user passes missing attr (#44)

srid · Mar 1, 2024 · 9999f86 · 9999f86
1 parent d822a5f
commit 9999f86
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 - Fixes
     - Fix regression in Nix 2.19+ (`devour-flake produced an outpath with no outputs`) (\#35)
     - Evaluate OS configurations for current system only (\#38)
+    - Fail correctly if nixci is passed a missing flake attribute (\#44)
 
 # 0.2.0
 

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -27,7 +27,8 @@ reqwest = { version = "0.11", features = ["blocking", "json"] }
 try-guard = "0.2.0"
 clap = { version = "4.4", features = ["derive"] }
 urlencoding = "2.1.3"
-nix_rs = { version = "0.2.3" }
+nix_rs = { version = "0.3.0" }
+# nix_rs = { version = "0.3", path = "../nix-browser/crates/nix_rs" }
 tracing-subscriber = { version = "0.3.17", features = ["env-filter"] }
 tracing = "0.1.37"
 

diff --git a/src/config.rs b/src/config.rs
@@ -36,7 +36,7 @@ impl Config {
         let (url, attr) = url.split_attr();
         let name = attr.get_name();
         let nixci_url = FlakeUrl(format!("{}#nixci.{}", url.0, name));
-        let cfg = nix_eval_attr_json::<Config>(&nixci_url).await?;
+        let cfg = nix_eval_attr_json::<Config>(&nixci_url, attr.is_none()).await?;
         Ok(((name, cfg), url))
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,6 +7,7 @@ @@
     - Fixes
         - Fix regression in Nix 2.19+ (`devour-flake produced an outpath with no outputs`) (\#35)
         - Evaluate OS configurations for current system only (\#38)
+        - Fail correctly if nixci is passed a missing flake attribute (\#44)
     # 0.2.0
@@ Expand Down @@