Address review comments

srinivasreddy · Feb 5, 2025 · 2f46caf · 2f46caf
1 parent f1cb1e3
commit 2f46caf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
@@ -4501,8 +4501,8 @@ def __getattribute__(self, x):
                 print(x)
                 print(qq)
 
-        for name, instance in (("a", A()), ("b", B())):
-            with self.subTest(name=name):
+        for instance in (A(), B()):
+            with self.subTest(instance=instance):
                 actual = self.get_suggestion(instance, "pop")
                 self.assertIn("name 'qq' is not defined", actual)
                 self.assertEqual(actual.count("NameError"), 1)

diff --git a/Lib/traceback.py b/Lib/traceback.py
@@ -1523,7 +1523,7 @@ def _compute_suggestion_error(exc_value, tb, wrong_name):
             try:
                 if hasattr(self, wrong_name):
                     return f"self.{wrong_name}"
-            except Exception:
+            except NameError:
                 return None
 
     try: