Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version-specific config tunings and custom prompt for SR Linux #1740

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Nov 23, 2023

No description provided.

@hellt hellt changed the title Move srl config template to a file and add version-specific config func Version-specific config tunings and custom prompt for SR Linux Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1740 (b226787) into main (2184f2d) will increase coverage by 0.39%.
Report is 11 commits behind head on main.
The diff coverage is 78.37%.

❗ Current head b226787 differs from pull request most recent head 1e12413. Consider uploading reports for the commit 1e12413 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
+ Coverage   51.55%   51.95%   +0.39%     
==========================================
  Files         143      144       +1     
  Lines       13807    13890      +83     
==========================================
+ Hits         7118     7216      +98     
+ Misses       5898     5872      -26     
- Partials      791      802      +11     
Files Coverage Δ
nodes/srl/srl.go 58.58% <87.80%> (+0.97%) ⬆️
nodes/srl/prompt.go 66.66% <66.66%> (ø)

... and 13 files with indirect coverage changes

@hellt hellt merged commit 47b89b9 into main Nov 23, 2023
1 check passed
@hellt hellt deleted the srl-template-in-a-file branch November 23, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant