Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for __clabNodeName__ magic var #2257

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

hyposcaler-bot
Copy link
Contributor

Adds clabNodeName

Should work for node/kind/default as described/asked in #1931

Added some primitive unit test for it in config_test.go
Also updates doc/manual/nodes.md mostly by copying the basic flow and content for the notes on clabNodeDir

@hellt hellt self-assigned this Oct 31, 2024
@hellt
Copy link
Member

hellt commented Oct 31, 2024

OOO this week, will get to it once I am back
thank you!

@kaelemc
Copy link
Contributor

kaelemc commented Dec 8, 2024

OOO this week, will get to it once I am back

@hellt that is sure one long week 😅

I took the liberty of trying it out myself.

This is honestly brilliant, I tested __clabNodeName__ under defaults: and under each node individually, working perfectly.. seems like this makes the configs much easier.

@hyposcaler-bot nice work, nothing else to say, it does exactly what it says on the box 👍

@hellt hellt changed the title adds support for __clabNodeName__ magic var adds support for __clabNodeName__ magic var Jan 3, 2025
@hellt
Copy link
Member

hellt commented Jan 3, 2025

a week became a month :D sorry
waiting for the pipeline to finish and then merging this beauty

@hellt hellt merged commit 4f0d1cd into srl-labs:main Jan 3, 2025
67 checks passed
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 51.86%. Comparing base (9e96472) to head (eb74eee).
Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
mocks/mocknodes/default_node.go 0.00% 18 Missing ⚠️
mocks/mocknodes/node.go 0.00% 3 Missing ⚠️
mocks/mockruntime/runtime.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
+ Coverage   51.18%   51.86%   +0.68%     
==========================================
  Files         172      172              
  Lines       16689    17256     +567     
==========================================
+ Hits         8542     8950     +408     
- Misses       7235     7366     +131     
- Partials      912      940      +28     
Files with missing lines Coverage Δ
clab/config.go 67.69% <100.00%> (+1.03%) ⬆️
mocks/mockruntime/runtime.go 10.22% <0.00%> (-0.38%) ⬇️
mocks/mocknodes/node.go 5.12% <0.00%> (ø)
mocks/mocknodes/default_node.go 0.00% <0.00%> (ø)

... and 58 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants