fix(asav): get builds working and asav booting #402
+53
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2025
Open
|
SSH is tested and working now. |
|
Nice work, I will take a look. Things are just a bit busy right now 😅 |
|
@kaelemc any update? I'd like to get this in place so I can start looking at adding support in containerlab. Let me know if there's anything I can do to make review easier. |
|
Hey sorry, been travelling.. After the next few days I should be able to review. Apologies |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the existing configurations to work with newer
asavversions, including 9.23.1 which is what this was tested against.I have no background with this project so could very well be missing something important.
As an example, I noticed that the device configures itselft after starting the container which can take some time and the SSH port responds but I am never able to directly SSH into the container. Maybe someone can help point me in the right direction to fix this? I see the username and password are being set correctly so not sure if there is some other config that should be injected.
Relates to srl-labs/containerlab#2897.