Skip to content

Conversation

@h4ndzdatm0ld
Copy link

Changed config load to config replace in sonic/docker/backup.sh to ensure user-provided startup configurations completely replace the default config instead of merging with it. This provides deterministic, predictable device configurations when deploying SONIC containers with custom config_db.json files.

@hellt
Copy link
Member

hellt commented Nov 3, 2025

thanks @h4ndzdatm0ld

let me check with the original PR author if there was a use case behind the merge behavior

@adam-kulagowski, do you remember why you went with load and not replace?

@adam-kulagowski
Copy link

Nothing comes to my mind - unfortunately it was over a year ago. Replace do sounds like a better approach though :)

@hellt hellt merged commit 6b3d69c into srl-labs:master Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants