Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct nested <li> structure in Card component at Education section #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaspify
Copy link

@yaspify yaspify commented Jan 26, 2025

Description

This PR addresses an issue with the incorrect nesting of <li> elements in the Card component, which caused semantic and rendering problems. The following updates have been made:

  • Wrapped the nested <li> element in a <ul> to ensure proper semantic structure.

Before Fix

The nested <li> was improperly placed directly inside another <li>, violating semantic HTML rules and potentially causing issues with screen readers and layout.

After Fix

The nested <li> has been correctly wrapped within a <ul>, ensuring:

  • Accessibility improvements for screen readers.
  • Proper rendering and adherence to HTML standards.

Let me know if you’d like to adjust or add anything!

…tion

Wrapped the nested <li> within a <ul> for semantic correctness.
Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-theme-resume ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 6:05am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant