-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark this CSS file as containing unicode #20
base: main
Are you sure you want to change the base?
Conversation
The root file already has this marker, so you'd hope that this wouldn't be needed, however we have seen build failures where developers don't have a suitable locale set, which this aims to avoid.
Just tried this and I get the same result as before. Output
|
So it turns out this is an issue specific to my setup. Upon changing the Region setting to United Kingdom, my locale changed to |
This is very odd. It looks like this is essentially jekyll/jekyll#4268. I can get this to fail if I forcibly remove @raccube could you try the suggestion around the config setting mentioned in jekyll/jekyll#4268 (comment) and report back? I suspect it won't work here given that it didn't work there. The other option would be to use escape sequences, though I'd really still want to have the actual characters in place for easier reading and I suspect that comments may also fall afoul of this issue. That might be worth testing too though. |
Setting |
Yeah, this is because those first two lines are what tell Jekyll that these sass files should be processed. It's unsurprising that if they're removed that the error doesn't happen, since the whole of the sass parsing isnt' happening. |
The other thing which might be interesting to try would be to add a unicode BOM to the file. Again I'm not sure I like that nor am I convinced that it's going to work if your locale actually doesn't have a unicode codec available (though that being the case is just ludicrous these days). |
There is a UTF-8 version of the default locale ( |
The root file already has this marker, so you'd hope that this wouldn't be needed, however we have seen build failures where developers don't have a suitable locale set, which this aims to avoid.
Note: this is a speculative change pending testing.