Avoid wildcard imports and mention enums #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's bad practice, and should be explicit where the values came from.
WillB97
reviewed
Oct 28, 2024
It's not very useful to teams to know they're grouped Co-authored-by: Will Barber <[email protected]>
It's not quite enough to be in the Whirlwind tour
Co-authored-by: Will Barber <[email protected]>
RealOrangeOne
changed the title
WillB97
approved these changes
Dec 10, 2024
Alexbruvv
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's bad practice, and should be explicit where the values came from.
This also explicitly talks about enums, what they are, and how to use them (correctly and incorrectly).