Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robots 101 page about motors #644

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

RealOrangeOne
Copy link
Member

@RealOrangeOne RealOrangeOne commented Nov 23, 2024

Fixes #647

@RealOrangeOne RealOrangeOne marked this pull request as draft November 23, 2024 16:36
@RealOrangeOne RealOrangeOne marked this pull request as ready for review November 24, 2024 16:18
@@ -0,0 +1,112 @@
---
layout: page
title: Robots 101 - Motors
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: "Motors" in "Robots 101" could imply there's more here than just how to use the motors API.

Perhaps putting this content under "Robots 101" isn't the right place?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. From the title I'd assumed this was also about motors themselves, perhaps including suggestions on how to pick them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking again this page feels like it has a lot of overlap with https://studentrobotics.org/docs/tutorials/basic_motor_control, is that expected?
There is good/new content in this PR, which would definitely be valuable to have in our docs, so maybe an alternative is to review the existing tutorial and either merge this or break out separate sub-pages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorials - Robots 101 - Motors
2 participants