This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Add DEBUG-level logging of all Interface method calls #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses some funky introspection whenever a Backend is registered to: * get all of the interfaces it implements * get all of the abstract methods of these interfaces (component-backend interactions) * install a wrapper around each method * use the call signature of the method to get a mapping of the arguments to the call with both names and values * log the method name, arguments and return value... * ...to the logger named by the module that the interface is defined in! This code contains copious amounts of black magic. Perhaps manually adding log messages to every interface method would have been a more obvious if less efficient solution.
|
Code Climate has analyzed commit 807db9b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 89.1% (0.0% change). View more on Code Climate. |
Closed
|
This is both nice and not nice. I'm happy to ship it for now, but I'd like to review whether we will want it in a month As for verboseness, j5 won't have any other level, so I'm unsure what to do. @sedders123 @RealOrangeOne opinions? |
trickeydan
approved these changes
Aug 6, 2019
|
I've opened #370 to track cleaning this up at a later date. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses some funky introspection whenever a Backend is registered to:
This code contains copious amounts of black magic. Perhaps manually
adding log messages to every interface method would have been a more
obvious if less efficient solution.
Since writing this I think it might be too verbose for typical debugging efforts. Thoughts on defining a new log level below
DEBUGe.g.TRACE?