Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: godmode #5920

Merged
merged 14 commits into from
Sep 22, 2024
Merged

refactor: godmode #5920

merged 14 commits into from
Sep 22, 2024

Conversation

Antoonij
Copy link
Contributor

Описание

Режим бога переезжает в трейт для более приятной работы с ним, освобождая место для статус эффектов kotvshlyapi

Ссылка на предложение/Причина создания ПР

могу дать на эшапдейт, но в этом смысла нет

Тесты

не нужны

Den109G
Den109G reviewed Sep 18, 2024
View reviewed changes
code/_globalvars/traits.dm Outdated Show resolved Hide resolved
Den109G
Den109G previously approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@Den109G Den109G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor. Выглядит всё работоспособным.

@Den109G Den109G added the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Sep 21, 2024
Daeberdir
Daeberdir requested changes Sep 22, 2024
View reviewed changes
code/datums/spells/shapeshift.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/anomaly_extract.dm Outdated Show resolved Hide resolved
code/modules/antagonists/vampire/vampire_powers/bestia_powers.dm Show resolved Hide resolved
code/modules/power/tesla/energy_ball.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/hulk.dm Show resolved Hide resolved
@Den109G Den109G removed the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Sep 22, 2024
Daeberdir
Daeberdir approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@Daeberdir Daeberdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Теперь должно работать хорошо.

@Daeberdir Daeberdir added the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Sep 22, 2024
@Den109G Den109G added this pull request to the merge queue Sep 22, 2024
Merged via the queue into ss220-space:master220 with commit 9c4bfea Sep 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den109G Den109G Den109G approved these changes

@Daeberdir Daeberdir Daeberdir approved these changes

Assignees
No one assigned
Labels
Has Approve Have been approved by somebody from Review Team and awaiting for one more approve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Antoonij @Den109G @Daeberdir