Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: devouring #5922

Closed
wants to merge 38 commits into from
Closed

Conversation

Antoonij
Copy link
Contributor

@Antoonij Antoonij commented Sep 19, 2024

Описание

Только после мержа #5926 (Перееду с онклика на унармед атаки)

Атака морфа и дракона (поедание) переезжают в компонент, ибо потанцевала на такое хватает
Поедание крысок, ксеноморфов и т.д было решено не трогать и оставить на уровне базового кода, ибо будем тянуть костыли, либо неправильное поведение

Ссылка на предложение/Причина создания ПР

так как звея нет, то рефакторы пилю я

Тесты

не могу

@Antoonij Antoonij marked this pull request as ready for review September 19, 2024 09:22
@Ssheya
Copy link
Contributor

Ssheya commented Sep 19, 2024

Vore? Одобряем.

@LiquidPotroh
Copy link
Contributor

Ксеносов тестил? Там что то какое то непонятное поведение было, как раз видимо в коде поедания.

@LiquidPotroh
Copy link
Contributor

Хотя на тестах у всех все работает, а на серверах ноу воре :(

@Antoonij Antoonij marked this pull request as draft September 19, 2024 12:15
@Antoonij Antoonij changed the title refactor: devouring dragon attack & morph attack refactor: devouring & advanced devouring Sep 19, 2024
@Ssheya
Copy link
Contributor

Ssheya commented Sep 19, 2024

Хотя на тестах у всех все работает, а на серверах ноу воре :(

суки не дают ворить на сервере :(

@Antoonij Antoonij changed the title refactor: devouring & advanced devouring refactor: devouring Sep 20, 2024
@Antoonij Antoonij marked this pull request as ready for review September 20, 2024 10:01
@Antoonij Antoonij marked this pull request as draft September 21, 2024 05:19
@github-actions github-actions bot added the Merge Conflict This doesn't seem right label Sep 28, 2024
@github-actions github-actions bot removed the Merge Conflict This doesn't seem right label Sep 28, 2024
@github-actions github-actions bot added the Merge Conflict This doesn't seem right label Oct 13, 2024
@Antoonij Antoonij closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants