-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade vomit from life cycle to debuff #5931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antoonij
changed the title
refactor: Handle random events in life cycle
refactor: Upgrade vomit from life cycle to debuff
Sep 27, 2024
Den109G
reviewed
Oct 6, 2024
Den109G
previously approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выглядит хорошо.
Den109G
added
the
Has Approve
Have been approved by somebody from Review Team and awaiting for one more approve
label
Oct 6, 2024
Daeberdir
requested changes
Oct 8, 2024
Den109G
previously approved these changes
Oct 8, 2024
Daeberdir
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Теперь оно работает, с подушкой безопасности и прочей дрянью без лишней дряни.
Den109G
approved these changes
Oct 8, 2024
Daeberdir
removed
the
Has Approve
Have been approved by somebody from Review Team and awaiting for one more approve
label
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описаниe
Взял с тг и улучшил под наш билд. Теперь рвота вызывается статус эффектом, который происходит в SetToxLoss и AdjustToxLoss, когда достигаются условия дефайна
Ссылка на предложение/Причина создания ПР
всегда должен быть тот, кто делает 100 страниц рефакторов
Тесты
не могу catrose