Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade vomit from life cycle to debuff #5931

Merged
merged 33 commits into from
Oct 8, 2024

Conversation

Antoonij
Copy link
Contributor

Описаниe

Взял с тг и улучшил под наш билд. Теперь рвота вызывается статус эффектом, который происходит в SetToxLoss и AdjustToxLoss, когда достигаются условия дефайна

Ссылка на предложение/Причина создания ПР

всегда должен быть тот, кто делает 100 страниц рефакторов

Тесты

не могу catrose

@Antoonij Antoonij changed the title refactor: Handle random events in life cycle refactor: Upgrade vomit from life cycle to debuff Sep 27, 2024
@github-actions github-actions bot added the Merge Conflict This doesn't seem right label Oct 1, 2024
@github-actions github-actions bot removed the Merge Conflict This doesn't seem right label Oct 2, 2024
@Antoonij Antoonij requested a review from Den109G October 6, 2024 15:57
Den109G
Den109G previously approved these changes Oct 6, 2024
Copy link
Contributor

@Den109G Den109G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит хорошо.

@Den109G Den109G added the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Oct 6, 2024
code/modules/mob/living/carbon/carbon.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/carbon.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/carbon.dm Outdated Show resolved Hide resolved
code/__DEFINES/mobs.dm Outdated Show resolved Hide resolved
Den109G
Den109G previously approved these changes Oct 8, 2024
Copy link
Member

@Daeberdir Daeberdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Теперь оно работает, с подушкой безопасности и прочей дрянью без лишней дряни.

@Den109G Den109G added this pull request to the merge queue Oct 8, 2024
@Daeberdir Daeberdir removed the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Oct 8, 2024
Merged via the queue into ss220-space:master220 with commit bde24da Oct 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants