Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calling libcec_close twice on drop #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix calling libcec_close twice on drop #46

wants to merge 1 commit into from

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Sep 12, 2024 •
edited
Loading

The libcec_close call in CecConnection::drop is unnecessary because libcec_destroy already calls libcec_close: https://github.com/Pulse-Eight/libcec/blob/libcec-6.0.2/src/libcec/LibCECC.cpp#L53-L61

@ssalonen
Copy link
Owner

Lint seems to be breaking with old untouched code. Not related to this PR - just new rules...

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Sep 13, 2024 •
edited
Loading

Ok! I just created a new PR for that here: #50. I can rebase the other PRs once that is in to make it easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kira-bruneau @ssalonen