Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Integrate simularium file generation in exec combine function #137

Merged
merged 3 commits into from
Feb 1, 2024
Merged

feat: Integrate simularium file generation in exec combine function #137

merged 3 commits into from
Feb 1, 2024

Conversation

AlexPatrie
Copy link
Collaborator

What does this PR do?:

  • Adds biosimulators-simularium>=0.5.24 as a dependency for the Python bindings of Smoldyn.
  • Implements Simularium file generation inside the body of the exec_sedml_docs_in_combine_archive function within the smoldyn.biosimulators.combine.py Python binding.
  • Adds a test for the aforementioned content.

@AlexPatrie AlexPatrie requested a review from ssandrews February 1, 2024 18:59
@ssandrews ssandrews merged commit dfda744 into master Feb 1, 2024
0 of 26 checks passed
@ssandrews ssandrews deleted the integrate-simularium branch February 1, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssandrews ssandrews Awaiting requested review from ssandrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexPatrie @ssandrews