Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noUse opt #26

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add noUse opt #26

merged 2 commits into from
Nov 7, 2023

Conversation

Powersource
Copy link
Contributor

@Powersource
Copy link
Contributor Author

tests "failing" but it's only the licenses and that's old i guess

This was referenced Oct 26, 2023
Closed
Merged
mixmix
mixmix requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this addition. For me noUse suggests that the sbot.use function will be disabled?

Other ideas which could be clearer:

  • noDb: true
  • db: dbPlugin for custom db module , or db: false to have none

@Powersource
Copy link
Contributor Author

renamed it to noDefaultUse

@Powersource Powersource requested a review from mixmix October 31, 2023 11:47
@Powersource Powersource merged commit 4a8337b into master Nov 7, 2023
@Powersource Powersource deleted the no-use branch November 7, 2023 13:08
@Powersource
Copy link
Contributor Author

v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixmix mixmix mixmix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Powersource @mixmix