Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook demos #50

Merged
merged 11 commits into from
Jan 12, 2025
Merged

Notebook demos #50

merged 11 commits into from
Jan 12, 2025

Conversation

fexfl
Copy link
Collaborator

@fexfl fexfl commented Nov 19, 2024

  • Added notebook folder with demos for usage and for performance
  • Usage demonstration output is currently just printed, find a way to visualize this better in the future

@fexfl fexfl requested a review from iulusoy November 19, 2024 14:09
@fexfl
Copy link
Collaborator Author

fexfl commented Nov 19, 2024

This addresses #40 and #42, but further work is needed to visualize the results better

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (873c0a7) to head (3e0dd91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files           4        4           
  Lines         383      383           
=======================================
  Hits          358      358           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iulusoy iulusoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some remarks and description for the demo notebook. Please address the remarks in the performance notebook. For the performance, we would also like to try batching for the transformers pipeline (see latest issue, that would be a new PR).

Can you make sure to use precommit hooks, so that the jupyter notebook output is cleared when you commit to the repo (execute pre-commit install in your directory).

notebook/performance_demo.ipynb Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

@fexfl fexfl merged commit dd841fc into main Jan 12, 2025
9 checks passed
@fexfl fexfl deleted the notebook-demonstration branch January 12, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants