-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook demos #50
Notebook demos #50
Conversation
fexfl
commented
Nov 19, 2024
- Added notebook folder with demos for usage and for performance
- Usage demonstration output is currently just printed, find a way to visualize this better in the future
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 4 4
Lines 383 383
=======================================
Hits 358 358
Misses 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some remarks and description for the demo notebook. Please address the remarks in the performance notebook. For the performance, we would also like to try batching for the transformers pipeline (see latest issue, that would be a new PR).
Can you make sure to use precommit hooks, so that the jupyter notebook output is cleared when you commit to the repo (execute pre-commit install
in your directory).
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |