Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backend changes from #183 add-trafficlight-feedback #192

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Nov 27, 2024

  • implements statistics computation for milestonegroups
  • adds the computation of the trafficlight feedback
  • adds various routes
  • adds tests
  • Needs to be refactored to use the new MilestoneAnswer

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 135 lines in your changes missing coverage. Please review.

Project coverage is 1.51%. Comparing base (78c1a9e) to head (e9f89bb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ntend/src/lib/components/Admin/AgeIntervals.svelte 0.00% 60 Missing and 1 partial ⚠️
...c/lib/components/Admin/EditAgeIntervalModal.svelte 0.00% 45 Missing and 1 partial ⚠️
...nd/src/lib/components/Admin/MilestoneGroups.svelte 0.00% 11 Missing ⚠️
frontend/src/lib/components/MilestoneGroup.svelte 0.00% 9 Missing ⚠️
...src/lib/components/Admin/EditMilestoneModal.svelte 0.00% 7 Missing ⚠️
frontend/src/lib/components/AdminPage.svelte 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (78c1a9e) and HEAD (e9f89bb). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (78c1a9e) HEAD (e9f89bb)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #192       +/-   ##
==========================================
- Coverage   30.16%   1.51%   -28.66%     
==========================================
  Files         103      82       -21     
  Lines        3388    2513      -875     
  Branches       91      94        +3     
==========================================
- Hits         1022      38      -984     
- Misses       2290    2396      +106     
- Partials       76      79        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaHaWo and others added 27 commits November 27, 2024 13:09
commit 4f0a845
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 14:49:33 2024 +0100

    reformat and remove unnecessary changes

commit 296a62e
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 14:39:26 2024 +0100

    add missing localiztion thing

commit ce3a806
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 14:33:40 2024 +0100

    adjust python tests to the presence of age_interval

commit 6b783ac
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 09:44:03 2024 +0100

    fix bug that would display milestonegroups for which there are no data

commit 9e78793
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 09:32:26 2024 +0100

    modify age filtering to use milestone ageintervals

commit 4e4c66b
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 13:31:02 2024 +0100

    include age interval into milestone admin page

commit a7c41d4
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 13:00:19 2024 +0100

    add better styling

commit 5ef829a
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 12:44:15 2024 +0100

    finish frontend part with respective corrections to backend

commit 002b9b9
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 07:20:53 2024 +0100

    make ageinterval editable.

commit 7ac5e05
Author: Harald Mack <[email protected]>
Date:   Wed Nov 27 15:52:55 2024 +0100

    work on ageinterval frontend

commit 7e302c2
Author: Harald Mack <[email protected]>
Date:   Wed Nov 27 15:13:12 2024 +0100

    add routes, models for age intervals and start adding frontend stuff
Copy link

sonarcloud bot commented Dec 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants