Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backend changes from #183 add-trafficlight-feedback #192

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Nov 27, 2024

  • implements statistics computation for milestonegroups
  • adds the computation of the trafficlight feedback
  • adds various routes
  • adds tests
  • Needs to be refactored to use the new MilestoneAnswer

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 88.62069% with 33 lines in your changes missing coverage. Please review.

Project coverage is 33.86%. Comparing base (016988c) to head (779f1e5).

Files with missing lines Patch % Lines
...y_backend/src/mondey_backend/routers/milestones.py 35.71% 18 Missing ⚠️
...ondey_backend/src/mondey_backend/routers/scores.py 90.42% 9 Missing ⚠️
mondey_backend/src/mondey_backend/routers/users.py 86.20% 4 Missing ⚠️
...y_backend/src/mondey_backend/routers/statistics.py 97.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   29.86%   33.86%   +4.00%     
==========================================
  Files         104      106       +2     
  Lines        3422     3679     +257     
  Branches       92       92              
==========================================
+ Hits         1022     1246     +224     
- Misses       2323     2356      +33     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaHaWo and others added 27 commits November 27, 2024 13:09
commit 4f0a845
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 14:49:33 2024 +0100

    reformat and remove unnecessary changes

commit 296a62e
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 14:39:26 2024 +0100

    add missing localiztion thing

commit ce3a806
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 14:33:40 2024 +0100

    adjust python tests to the presence of age_interval

commit 6b783ac
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 09:44:03 2024 +0100

    fix bug that would display milestonegroups for which there are no data

commit 9e78793
Author: Harald Mack <[email protected]>
Date:   Fri Nov 29 09:32:26 2024 +0100

    modify age filtering to use milestone ageintervals

commit 4e4c66b
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 13:31:02 2024 +0100

    include age interval into milestone admin page

commit a7c41d4
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 13:00:19 2024 +0100

    add better styling

commit 5ef829a
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 12:44:15 2024 +0100

    finish frontend part with respective corrections to backend

commit 002b9b9
Author: Harald Mack <[email protected]>
Date:   Thu Nov 28 07:20:53 2024 +0100

    make ageinterval editable.

commit 7ac5e05
Author: Harald Mack <[email protected]>
Date:   Wed Nov 27 15:52:55 2024 +0100

    work on ageinterval frontend

commit 7e302c2
Author: Harald Mack <[email protected]>
Date:   Wed Nov 27 15:13:12 2024 +0100

    add routes, models for age intervals and start adding frontend stuff
MaHaWo and others added 25 commits December 5, 2024 13:27
…dey-frontend-prototype into trafficlight-feedback-backend
…dey-frontend-prototype into trafficlight-feedback-backend
Copy link

sonarcloud bot commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants