Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multiple images in Milestone component #58

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Sep 16, 2024

@lkeegan lkeegan force-pushed the fix_51_milestone_images_carousel branch from 39ff4d6 to 2a1de2f Compare September 16, 2024 12:43
- milestone component cycles through available images for that milestone
- transition via opacity every 5secs
- provide list of image urls in demo data instead of a single image
- remove padding on mobile devices to use more of the screen
- increase max width of Milestone component on large screens
- resolves #51
@lkeegan lkeegan force-pushed the fix_51_milestone_images_carousel branch from 2a1de2f to 1deeebb Compare September 16, 2024 12:47
@lkeegan lkeegan requested a review from MaHaWo September 16, 2024 12:47
Copy link
Collaborator

@MaHaWo MaHaWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one minor remark wrt delay between images

frontend/src/lib/components/Milestone.svelte Show resolved Hide resolved
@lkeegan lkeegan merged commit bc17c1b into main Sep 17, 2024
3 checks passed
@lkeegan lkeegan deleted the fix_51_milestone_images_carousel branch September 17, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple images in frontend Milestone component as carousel
2 participants