Skip to content

Commit

Permalink
Drop support for Python 3.8. (#504)
Browse files Browse the repository at this point in the history
* Remove support for Python 3.8. It will be end-of-life in October 2024.
* Add pylint ignore for too many positional arguments to a config method.
  • Loading branch information
tdenewiler authored Sep 23, 2024
1 parent 1857689 commit 954fc18
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, ubuntu-20.04, ubuntu-22.04, windows-latest]
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.9', '3.10', '3.11']

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## Unreleased

Removed support for Python 3.8.

### Added

- Allow short flag names. (#489, @qdang922)
Expand All @@ -26,6 +28,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Fix command used to run ruff tool.
- Ruff v0.5.0 requires use of `ruff check` instead of `ruff`.
- Update list of files in clean script to fix shellscript warnings about globs for files with hyphens.
- Ignore new pylint finding for too many positional arguments.
Finding showed up with pylint 3.3.0.

## v0.9.4 - 2022-04-25

Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
classifiers=[
"License :: CC0 1.0 Universal (CC0 1.0) Public Domain Dedication",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
2 changes: 1 addition & 1 deletion statick_tool/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def str_to_bool(cls, val: Optional[str]) -> bool:
return False
return False

def get_plugin_config( # pylint: disable=too-many-arguments
def get_plugin_config( # pylint: disable=too-many-arguments, too-many-positional-arguments
self,
plugin_type: str,
plugin: str,
Expand Down
3 changes: 1 addition & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py38, py39, py310, py311
envlist = py39, py310, py311
skip_missing_interpreters = true

[pytest]
Expand Down Expand Up @@ -27,7 +27,6 @@ skip_glob = **/tests/plugins/tool/isort_tool_plugin/valid_package/*.py

[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
Expand Down

0 comments on commit 954fc18

Please sign in to comment.